netdev - Re: [PATCH iproute2] lib: Dump ext-ack string by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79db9ff1-69c3-5a16-fb67-54f1b79eb3a5@gmail.com>
Date:   Mon, 7 Aug 2017 13:36:49 -0600
From:   David Ahern <dsahern@...il.com>
To:     netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH iproute2] lib: Dump ext-ack string by default

On 8/7/17 1:28 PM, David Ahern wrote:
> @@ -99,7 +95,12 @@ static int nl_dump_ext_err(const struct nlmsghdr *nlh, nl_ext_ack_fn_t errfn)
>  			err_nlh = &err->msg;
>  	}
>  
> -	return errfn(errmsg, off, err_nlh);
> +	if (errfn)
> +		return errfn(errmsg, off, err_nlh);
> +
> +	fprintf(stderr, "Error: %s\n", errmsg);
> +
> +	return 1;


Dang it, missing an 'if (errmsg)' since it does not have to exist. Will
send a v2