netdev - Re: [patch net-next 00/15] net: sched: summer cleanup part 2, ndo_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 7 Aug 2017 08:21:28 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        daniel@...earbox.net, mlxsw@...lanox.com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com,
        simon.horman@...ronome.com, pieter.jansenvanvuuren@...ronome.com,
        dirk.vandermerwe@...ronome.com, alexander.h.duyck@...el.com,
        amritha.nambiar@...el.com, oss-drivers@...ronome.com
Subject: Re: [patch net-next 00/15] net: sched: summer cleanup part 2,
 ndo_setup_tc

Mon, Aug 07, 2017 at 08:09:01AM CEST, davem@...emloft.net wrote:
>From: Jiri Pirko <jiri@...nulli.us>
>Date: Mon, 7 Aug 2017 07:27:34 +0200
>
>> Mon, Aug 07, 2017 at 06:37:49AM CEST, davem@...emloft.net wrote:
>>>From: Jiri Pirko <jiri@...nulli.us>
>>>Date: Sat,  5 Aug 2017 16:53:22 +0200
>>>
>>>> From: Jiri Pirko <jiri@...lanox.com>
>>>> 
>>>> This patchset focuses on ndo_setup_tc and its args.
>>>> Currently there are couple of things that do not make much sense.
>>>> The type is passed in struct tc_to_netdev, but as it is always
>>>> required, should be arg of the ndo. Other things are passed as args
>>>> but they are only relevant for cls offloads and not mqprio. Therefore,
>>>> they should be pushed to struct. As the tc_to_netdev struct in the end
>>>> is just a container of single pointer, we get rid of it and pass the
>>>> struct according to type. So in the end, we have:
>>>> ndo_setup_tc(dev, type, type_data_struct)
>>>> 
>>>> There are couple of cosmetics done on the way to make things smooth.
>>>> Also, reported error is consolidated to eopnotsupp in case the
>>>> asked offload is not supported.
>>>
>>>Series applied, thanks Jiri.
>> 
>> Pushed this already? I just got an email from kbuildbot, I missed hns3pf
>> driver (3 days). I can send the fix as followup as well. Up to you.
>
>Luckily I didn't push yet, please respin with hns3pf fixed, thanks!

Will do. Thanks.