netdev - Re: [PATCH RFC net-next] net: Allow name change of IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170810162722.GH24790@lunn.ch>
Date:   Thu, 10 Aug 2017 18:27:22 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        network dev <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH RFC net-next] net: Allow name change of IFF_UP interfaces

On Thu, Aug 10, 2017 at 05:24:55PM +0200, Vitaly Kuznetsov wrote:
> Andrew Lunn <andrew@...n.ch> writes:
> 
> >> We are - rtnetlink_event() does the job. We, however, don't have a
> >> special IFLA_EVENT_* for name change and end up with IFLA_EVENT_NONE.
> >
> > What is in this event? Old and new name? Just the new name?
> 
> Basically, it's everything we know about the interface - type, index,
> name, mtu, qdisc, ... - see rtnl_fill_ifinfo(). Back to your question -
> it's only the new name.

So the program needs to keep track of ifindex to know which interface
has changed name. Doable.

I still expect this has the potential to break something. You probably
should be asking on linux-api for the API experts opinion.

       Andrew