netdev - RE: [patch v1 1/2] Allow Mellanox network vendor to be configured if only I2C bus is configured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR05MB1262B06790B2738CE1C0F889C88F0@VI1PR05MB1262.eurprd05.prod.outlook.com>
Date:   Sun, 13 Aug 2017 15:26:56 +0000
From:   Ohad Oz <ohado@...lanox.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "Saeed Mahameed" <saeedm@...lanox.com>,
        Vadim Pasternak <vadimp@...lanox.com>,
        system-sw-low-level <system-sw-low-level@...lanox.com>
Subject: RE: [patch v1 1/2] Allow Mellanox network vendor to be configured if
 only I2C bus is configured



> -----Original Message-----
> From: Leon Romanovsky [mailto:leon@...nel.org]
> Sent: Saturday, August 12, 2017 5:37 PM
> To: Ohad Oz <ohado@...lanox.com>
> Cc: davem@...emloft.net; netdev@...r.kernel.org; jiri@...nulli.us; Saeed
> Mahameed <saeedm@...lanox.com>; Vadim Pasternak
> <vadimp@...lanox.com>; system-sw-low-level <system-sw-low-
> level@...lanox.com>
> Subject: Re: [patch v1 1/2] Allow Mellanox network vendor to be configured
> if only I2C bus is configured
> 
> On Thu, Aug 10, 2017 at 05:11:51PM +0000, Ohad Oz wrote:
> > Patch allows Mellanox devices on system with no PCI, but with I2C only.
> >
> 
> Did you test mlx5 device on such system? Did it work for you?

Yes, I did. With PCI config set to disable mlx5 drivers are not built. 
Only the following: 
/build/drivers/net/Ethernet/mellanox/mlxsw/mlxsw_core.ko
/build/drivers/net/Ethernet/mellanox /mlxsw/mlxsw_i2c.ko
/build/drivers/net/Ethernet/mellanox /mlxsw/mlxsw_minimal.ko

While with both options on all drivers are built inc mlx5.


> What is the changelog between v0 and v1 of these patches?

No changelog, I've started with v1.

> 
> > Signed-off-by: Ohad Oz <ohado@...lanox.com>
> > ---
> >  drivers/net/ethernet/mellanox/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/Kconfig
> b/drivers/net/ethernet/mellanox/Kconfig
> > index 84a2007..0949741 100644
> > --- a/drivers/net/ethernet/mellanox/Kconfig
> > +++ b/drivers/net/ethernet/mellanox/Kconfig
> > @@ -5,7 +5,7 @@
> >  config NET_VENDOR_MELLANOX
> >  	bool "Mellanox devices"
> >  	default y
> > -	depends on PCI
> > +	depends on PCI || I2C
> >  	---help---
> >  	  If you have a network (Ethernet) card belonging to this class, say Y.
> >
> > --
> > 2.8.0
> >