netdev - Re: [iproute PATCH 06/51] iplink_vrf: Complain if main table is not found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cab9f83d-04a9-f676-d891-ee2cef5a1a7b@gmail.com>
Date:   Sun, 13 Aug 2017 09:58:55 -0600
From:   David Ahern <dsahern@...il.com>
To:     Phil Sutter <phil@....cc>,
        Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [iproute PATCH 06/51] iplink_vrf: Complain if main table is not
 found

On 8/12/17 6:04 AM, Phil Sutter wrote:
> Signed-off-by: Phil Sutter <phil@....cc>
> ---
>  ip/iplink_vrf.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/ip/iplink_vrf.c b/ip/iplink_vrf.c
> index 917630e853375..809eda5de8f6e 100644
> --- a/ip/iplink_vrf.c
> +++ b/ip/iplink_vrf.c
> @@ -131,7 +131,10 @@ __u32 ipvrf_get_table(const char *name)
>  					   &answer.n, sizeof(answer)) < 0) {
>  		/* special case "default" vrf to be the main table */
>  		if (errno == ENODEV && !strcmp(name, "default"))
> -			rtnl_rttable_a2n(&tb_id, "main");
> +			if (rtnl_rttable_a2n(&tb_id, "main"))
> +				fprintf(stderr,
> +					"BUG: RTTable \"main\" not found.\n");
> +
>  
>  		return tb_id;
>  	}
> 

Acked-by: David Ahern <dsahern@...il.com>