netdev - Re: [PATCH net-next] liquidio: update debug console logging mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170813055549.GO24282@mtr-leonro.local>
Date:   Sun, 13 Aug 2017 08:55:49 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Felix Manlunas <felix.manlunas@...ium.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        raghu.vatsavayi@...ium.com, derek.chickles@...ium.com,
        satananda.burla@...ium.com, ricardo.farrington@...ium.com
Subject: Re: [PATCH net-next] liquidio: update debug console logging mechanism

On Fri, Aug 11, 2017 at 06:43:14PM -0700, Felix Manlunas wrote:
> From: Rick Farrington <ricardo.farrington@...ium.com>
>
> - remove logging dependency upon global func octeon_console_debug_enabled()
> - abstract debug console logging using console structure (via function ptr)
>   to allow for more flexible logging
>
> Signed-off-by: Rick Farrington <ricardo.farrington@...ium.com>
> Signed-off-by: Raghu Vatsavayi <raghu.vatsavayi@...ium.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@...ium.com>
> ---
>  drivers/net/ethernet/cavium/liquidio/lio_main.c    | 44 +++++++++++++++++-
>  .../net/ethernet/cavium/liquidio/octeon_console.c  | 54 ++++++++++++++--------
>  .../net/ethernet/cavium/liquidio/octeon_device.h   | 17 +++++--
>  3 files changed, 90 insertions(+), 25 deletions(-)
>

I'm probably missing something important, but why do you need your custom console
implementation if kernel is full of such built-in options?

Thanks

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)