netdev - RE: [PATCH net-next] liquidio: update debug console logging mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY1PR0701MB1961883A407496B03A8FD870EC8C0@CY1PR0701MB1961.namprd07.prod.outlook.com>
Date:   Mon, 14 Aug 2017 16:28:50 +0000
From:   Ricardo Farrington <Ricardo.Farrington@...ium.com>
To:     Leon Romanovsky <leon@...nel.org>,
        "Manlunas, Felix" <Felix.Manlunas@...ium.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Vatsavayi, Raghu" <Raghu.Vatsavayi@...ium.com>,
        "Chickles, Derek" <Derek.Chickles@...ium.com>,
        "Burla, Satananda" <Satananda.Burla@...ium.com>
Subject: RE: [PATCH net-next] liquidio: update debug console logging mechanism

Hi Leon - the code to which this patch applies handles a data stream from our card's firmware to the host (over PCI).
There are device-specific registers which are accessed to transfer log data from our firmware to the host.
I don't think there is kernel code that we could use to perform this; this is not general purpose host driver logging.

Rick

-----Original Message-----
From: Leon Romanovsky [mailto:leon@...nel.org] 
Sent: Saturday, August 12, 2017 10:56 PM
To: Manlunas, Felix <Felix.Manlunas@...ium.com>
Cc: davem@...emloft.net; netdev@...r.kernel.org; Vatsavayi, Raghu <Raghu.Vatsavayi@...ium.com>; Chickles, Derek <Derek.Chickles@...ium.com>; Burla, Satananda <Satananda.Burla@...ium.com>; Ricardo Farrington <Ricardo.Farrington@...ium.com>
Subject: Re: [PATCH net-next] liquidio: update debug console logging mechanism

On Fri, Aug 11, 2017 at 06:43:14PM -0700, Felix Manlunas wrote:
> From: Rick Farrington <ricardo.farrington@...ium.com>
>
> - remove logging dependency upon global func 
> octeon_console_debug_enabled()
> - abstract debug console logging using console structure (via function ptr)
>   to allow for more flexible logging
>
> Signed-off-by: Rick Farrington <ricardo.farrington@...ium.com>
> Signed-off-by: Raghu Vatsavayi <raghu.vatsavayi@...ium.com>
> Signed-off-by: Felix Manlunas <felix.manlunas@...ium.com>
> ---
>  drivers/net/ethernet/cavium/liquidio/lio_main.c    | 44 +++++++++++++++++-
>  .../net/ethernet/cavium/liquidio/octeon_console.c  | 54 ++++++++++++++--------
>  .../net/ethernet/cavium/liquidio/octeon_device.h   | 17 +++++--
>  3 files changed, 90 insertions(+), 25 deletions(-)
>

I'm probably missing something important, but why do you need your custom console implementation if kernel is full of such built-in options?

Thanks