netdev - Re: [PATCH net-next 8/8] liquidio: added support for ethtool --set-ring feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170813.194315.2299024672935275105.davem@davemloft.net>
Date:   Sun, 13 Aug 2017 19:43:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...ium.com,
        derek.chickles@...ium.com, satananda.burla@...ium.com,
        intiyaz.basha@...ium.com
Subject: Re: [PATCH net-next 8/8] liquidio: added support for ethtool
 --set-ring feature

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Fri, 11 Aug 2017 18:29:30 -0700

> +	if ((ering->rx_mini_pending) || (ering->rx_jumbo_pending))
> +		return -EINVAL;

Lots of unnecessary parenthesis, please remove.

> +	if ((rx_count == rx_count_old) && (tx_count == tx_count_old))
> +		return 0;

Likewise.