netdev - Re: [PATCH net-next] rtnelink: Move link dump consistency check out of the loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170813.194412.429768431959485148.davem@davemloft.net>
Date:   Sun, 13 Aug 2017 19:44:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jkbs@...hat.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] rtnelink: Move link dump consistency check
 out of the loop

From: Jakub Sitnicki <jkbs@...hat.com>
Date: Wed,  9 Aug 2017 17:39:12 +0200

> Calls to rtnl_dump_ifinfo() are protected by RTNL lock. So are the
> {list,unlist}_netdevice() calls where we bump the net->dev_base_seq
> number.
> 
> For this reason net->dev_base_seq can't change under out feet while
> we're looping over links in rtnl_dump_ifinfo(). So move the check for
> net->dev_base_seq change (since the last time we were called) out of the
> loop.
> 
> This way we avoid giving a wrong impression that there are concurrent
> updates to the link list going on while we're iterating over them.
> 
> Signed-off-by: Jakub Sitnicki <jkbs@...hat.com>

Applied, thanks.