netdev - Re: [PATCH net] openvswitch: fix skb_panic due to the incorrect actions attrlen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAML_gOfew0w7Zhna2+2XeLMh6qV73bYNkOnV_cZ07+OCbrD_jA@mail.gmail.com>
Date:   Tue, 15 Aug 2017 14:02:55 +0800
From:   Liping Zhang <zlpnobody@...il.com>
To:     Pravin Shelar <pshelar@....org>
Cc:     Liping Zhang <zlpnobody@....com>,
        Pravin Shelar <pshelar@...ira.com>,
        "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Neil McKee <neil.mckee@...on.com>
Subject: Re: [PATCH net] openvswitch: fix skb_panic due to the incorrect
 actions attrlen

2017-08-15 13:01 GMT+08:00 Pravin Shelar <pshelar@....org>:
[...]
>>  net/openvswitch/actions.c  | 39 +++++++++++++++++++++++++--------------
>>  net/openvswitch/datapath.c |  2 +-
>>  net/openvswitch/datapath.h |  1 +
>>  3 files changed, 27 insertions(+), 15 deletions(-)
>>
>> diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
>> index e4610676299b..799a22dfb89e 100644
>> --- a/net/openvswitch/actions.c
>> +++ b/net/openvswitch/actions.c
>> @@ -48,6 +48,7 @@ struct deferred_action {
>>         struct sk_buff *skb;
>>         const struct nlattr *actions;
>>         int actions_len;
>> +       int actions_attrlen;
>>
> Have you considered passing this value using struct ovs_skb_cb? That
> would save passing this parameter in all these functions.

Thanks for your reviewing.

Right, this will make codes more clean, I will send V2 later.