netdev - Re: [PATCH net repost] nfp: do not update MTU from BH in flower app

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170815061347.GA14861@vergenet.net>
Date:   Tue, 15 Aug 2017 08:13:48 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     David Miller <davem@...emloft.net>
Cc:     jakub.kicinski@...ronome.com, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net repost] nfp: do not update MTU from BH in flower app

On Fri, Aug 11, 2017 at 02:51:07PM -0700, David Miller wrote:
> From: Simon Horman <simon.horman@...ronome.com>
> Date: Fri, 11 Aug 2017 10:18:20 +0200
> 
> > The Flower app may receive a request to update the MTU of a representor
> > netdev upon receipt of a control message from the firmware. This requires
> > the RTNL lock which needs to be taken outside of the packet processing
> > path.
> > 
> > As a handling of this correctly seems a little to invasive for a fix simply
> > skip setting the MTU for now.
> > 
> > Relevant backtrace:
>  ...
> > Fixes: 948faa46c05b ("nfp: add support for control messages for flower app")
> > Signed-off-by: Simon Horman <simon.horman@...ronome.com>
> > Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> 
> Applied.

Thanks.

Could you pull net into net-next? I'd like to send up a follow-up
for net-next to allow processing of the MTU.