netdev - Re: [PATCH net] sfc: don't try and read ef10 data on non-ef10 NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170815.171945.2105794860753584290.davem@davemloft.net>
Date:   Tue, 15 Aug 2017 17:19:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     bkenward@...arflare.com
Cc:     netdev@...r.kernel.org, linux-net-drivers@...arflare.com,
        sbrivio@...hat.com
Subject: Re: [PATCH net] sfc: don't try and read ef10 data on non-ef10 NIC

From: Bert Kenward <bkenward@...arflare.com>
Date: Tue, 15 Aug 2017 14:55:32 +0100

> The MAC stats command takes a port ID, which doesn't exist on
> pre-ef10 NICs (5000- and 6000- series). This is extracted from the
> NIC specific data; we misinterpret this as the ef10 data structure,
> causing us to read potentially unallocated data. With a KASAN kernel
> this can cause errors with:
>    BUG: KASAN: slab-out-of-bounds in efx_mcdi_mac_stats
> 
> Fixes: 0a2ab4d988d7 ("sfc: set the port-id when calling MC_CMD_MAC_STATS")
> Reported-by: Stefano Brivio <sbrivio@...hat.com>
> Tested-by: Stefano Brivio <sbrivio@...hat.com>
> Signed-off-by: Bert Kenward <bkenward@...arflare.com>

Applied, thanks.