netdev - Re: [PATCH net-next] dsa: fix flow disector null pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170815.171918.489226613083440129.davem@davemloft.net>
Date:   Tue, 15 Aug 2017 17:19:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kraigatgoog@...il.com
Cc:     john@...ozen.org, andrew@...n.ch, dvyukov@...gle.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] dsa: fix flow disector null pointer

From: Craig Gallek <kraigatgoog@...il.com>
Date: Tue, 15 Aug 2017 09:43:40 -0400

> From: Craig Gallek <kraig@...gle.com>
> 
> A recent change to fix up DSA device behavior made the assumption that
> all skbs passing through the flow disector will be associated with a
> device. This does not appear to be a safe assumption.  Syzkaller found
> the crash below by attaching a BPF socket filter that tries to find the
> payload offset of a packet passing between two unix sockets.
 ...
> Fixes: 43e665287f93 ("net-next: dsa: fix flow dissection")
> Reported-by: Dmitry Vyukov <dvyukov@...gle.com>
> Signed-off-by: Craig Gallek <kraig@...gle.com>

Applied, thanks.