netdev - Re: [PATCH] net_sched: remove warning from qdisc_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170815.171710.1104857144261787251.davem@davemloft.net>
Date:   Tue, 15 Aug 2017 17:17:10 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     khlebnikov@...dex-team.ru
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com, jkosina@...e.cz,
        edumazet@...gle.com, jhs@...atatu.com
Subject: Re: [PATCH] net_sched: remove warning from qdisc_hash_add

From: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Date: Tue, 15 Aug 2017 16:39:05 +0300

> It was added in commit e57a784d8cae ("pkt_sched: set root qdisc
> before change() in attach_default_qdiscs()") to hide duplicates
> from "tc qdisc show" for incative deivices.
> 
> After 59cc1f61f ("net: sched: convert qdisc linked list to hashtable")
> it triggered when classful qdisc is added to inactive device because
> default qdiscs are added before switching root qdisc.
> 
> Anyway after commit ea3274695353 ("net: sched: avoid duplicates in
> qdisc dump") duplicates are filtered right in dumper.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>

Applied.