netdev - Re: [patch net-next repost 2/3] net/sched: Change cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXOKrT658X1ADfz=WmKryqUgzfOwUF6uTnPNG00EPOQdg@mail.gmail.com>
Date:   Wed, 16 Aug 2017 10:42:01 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Chris Mi <chrism@...lanox.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        David Miller <davem@...emloft.net>, mawilcox@...rosoft.com
Subject: Re: [patch net-next repost 2/3] net/sched: Change cls_flower to use IDR

On Wed, Aug 16, 2017 at 1:14 AM, Chris Mi <chrism@...lanox.com> wrote:
> Currently, all filters with the same priority are linked in a doubly
> linked list. Every filter should have a unique handle. To make the
> handle unique, we need to iterate the list every time to see if the
> handle exists or not when inserting a new filter. It is time-consuming.
> For example, it takes about 5m3.169s to insert 64K rules.
>
> This patch changes cls_flower to use IDR. With this patch, it
> takes about 0m1.127s to insert 64K rules. The improvement is huge.
>
> But please note that in this testing, all filters share the same action.
> If every filter has a unique action, that is another bottleneck.
> Follow-up patch in this patchset addresses that.
>
> Signed-off-by: Chris Mi <chrism@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

While you are on it, why only migrate cls_flower? I am sure
we have similar handle generators in other tc flters too.

Also, _possibly_ we may make the tc filter handle generator
generic?

Thanks.