netdev - Re: [PATCH net-next 3/3 v4] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cff6f8152b3390f0fc137549c72345a@codeaurora.org>
Date:   Wed, 16 Aug 2017 11:46:48 -0600
From:   Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        fengguang.wu@...el.com, dcbw@...hat.com, stephen@...workplumber.org
Subject: Re: [PATCH net-next 3/3 v4] drivers: net: ethernet: qualcomm: rmnet:
 Initial implementation

>> +struct rmnet_phys_ep_conf_s {
> 
> The name is cryptic. Why "_s"?
>> +
>> +struct rmnet_vnd_private_s {
> 
> Again, cryptic.
> 
> 
>> +	struct rmnet_logical_ep_conf_s local_ep;
>> +	u32 msg_enable;
>> +};

Hi Jiri

The _s was to indicate struct. I'll remove that.

>> +rx_handler_result_t rmnet_ingress_handler(struct sk_buff *skb)
>> +{
>> +	struct rmnet_phys_ep_conf_s *config;
> 
> I still fail to understand why the name of this is "config". Please
> change to something else across whole code. Including the name of the 
> struct.
> 
>> +	struct net_device *dev;
>> +	int rc;
>> +
>> +	if (!skb)
>> +		return RX_HANDLER_CONSUMED;
>> +
>> +	dev = skb->dev;
>> +	config = rmnet_get_phys_ep_config(skb->dev);
> 
> You have dev. Why not use dev?
> 
>> +rx_handler_result_t rmnet_rx_handler(struct sk_buff **pskb)
>> +{
>> +	return rmnet_ingress_handler(*pskb);
> 
> This is just silly. Why you don't have the content of 
> rmnet_ingress_handler
> right here?

I'll make these changes now.

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project