netdev - Re: [PATCH V4 net-next 21/21] net-next/hinic: Add select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170816.114721.2286909258495579175.davem@davemloft.net>
Date:   Wed, 16 Aug 2017 11:47:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     aviad.krawczyk@...wei.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bc.y@...wei.com, victor.gissin@...wei.com, zhaochen6@...wei.com,
        tony.qu@...wei.com
Subject: Re: [PATCH V4 net-next 21/21] net-next/hinic: Add select_queue and
 netpoll

From: Aviad Krawczyk <aviad.krawczyk@...wei.com>
Date: Wed, 16 Aug 2017 20:03:06 +0800

> +static u16 hinic_select_queue(struct net_device *netdev, struct sk_buff *skb,
> +			      void *accel_priv,
> +			      select_queue_fallback_t fallback)
> +{
> +	u16 qid;
> +
> +	if (skb_rx_queue_recorded(skb))
> +		qid = skb_get_rx_queue(skb);
> +	else
> +		qid = fallback(netdev, skb);
> +
> +	return qid;
> +}

This is a NOP, do not implement this function unless you absolutely need to
do something custom in your driver, and you do not.