netdev - Re: [PATCH V4 net-next 21/21] net-next/hinic: Add select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44b1896a-01c0-ab0b-ede9-8582edeac9a3@huawei.com>
Date:   Thu, 17 Aug 2017 15:46:43 +0300
From:   Aviad Krawczyk <aviad.krawczyk@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <bc.y@...wei.com>, <victor.gissin@...wei.com>,
        <zhaochen6@...wei.com>, <tony.qu@...wei.com>
Subject: Re: [PATCH V4 net-next 21/21] net-next/hinic: Add select_queue and
 netpoll

Hi David,

Fixed in V6.
In V5 patch-set there was a problem in cover-letter msg-id.

Thanks,
Aviad

On 8/16/2017 9:47 PM, David Miller wrote:
> From: Aviad Krawczyk <aviad.krawczyk@...wei.com>
> Date: Wed, 16 Aug 2017 20:03:06 +0800
> 
>> +static u16 hinic_select_queue(struct net_device *netdev, struct sk_buff *skb,
>> +			      void *accel_priv,
>> +			      select_queue_fallback_t fallback)
>> +{
>> +	u16 qid;
>> +
>> +	if (skb_rx_queue_recorded(skb))
>> +		qid = skb_get_rx_queue(skb);
>> +	else
>> +		qid = fallback(netdev, skb);
>> +
>> +	return qid;
>> +}
> 
> This is a NOP, do not implement this function unless you absolutely need to
> do something custom in your driver, and you do not.
> 
> .
>