netdev - Re: [PATCH net-next] bpf: no need to nullify ri->map in xdp_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5995BD78.1070808@gmail.com>
Date:   Thu, 17 Aug 2017 08:59:52 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>, davem@...emloft.net
CC:     ast@...com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bpf: no need to nullify ri->map in xdp_do_redirect

On 08/17/2017 06:07 AM, Daniel Borkmann wrote:
> We are guaranteed to have a NULL ri->map in this branch since
> we test for it earlier, so we don't need to reset it here.
> 
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> ---
>  net/core/filter.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/core/filter.c b/net/core/filter.c
> index e9f8dce..ea3ca34 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -2568,7 +2568,6 @@ int xdp_do_redirect(struct net_device *dev, struct xdp_buff *xdp,
>  
>  	fwd = dev_get_by_index_rcu(dev_net(dev), index);
>  	ri->ifindex = 0;
> -	ri->map = NULL;
>  	if (unlikely(!fwd)) {
>  		bpf_warn_invalid_xdp_redirect(index);
>  		return -EINVAL;
> 

Thanks this was on my todo list as well.

Acked-by: John Fastabend <john.fastabend@...il.com>