netdev - Re: [PATCH 1/2] ixgbe: change ndo_xdp_xmit return code on xmit errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5995E14A.3000002@gmail.com>
Date:   Thu, 17 Aug 2017 11:32:42 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] ixgbe: change ndo_xdp_xmit return code on xmit errors

On 08/17/2017 09:22 AM, Jesper Dangaard Brouer wrote:
> Use errno -ENOSPC ("No space left on device") when the XDP xmit
> have no space left on the TX ring buffer, instead of -ENOMEM.
> 
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
> ---
>

Seems like an improvement to me. You could also potentially
distinguish between DMA mapping errors and descriptor overrun
but likely not needed.

Acked-by: John Fastabend <john.fastabend@...il.com>