netdev - Re: [PATCH net-next] dsa: remove unused net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170817184058.GA7154@breakpoint.cc>
Date:   Thu, 17 Aug 2017 20:40:58 +0200
From:   Florian Westphal <fw@...len.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
        f.fainelli@...il.com, vivien.didelot@...oirfairelinux.com
Subject: Re: [PATCH net-next] dsa: remove unused net_device arg from handlers

Andrew Lunn <andrew@...n.ch> wrote:
> On Thu, Aug 17, 2017 at 04:47:00PM +0200, Florian Westphal wrote:
> > compile tested only, but saw no warnings/errors with
> > allmodconfig build.
> >  
> >  static int dsa_switch_rcv(struct sk_buff *skb, struct net_device *dev,
> > -			  struct packet_type *pt, struct net_device *orig_dev)
> > +			  struct packet_type *pt, struct net_device *unused)
> 
> Hi Florian
> 
> Looks O.K. to me. I can test it out later.
> 
> Is there a bigger picture here? Do you plan to remove the second
> net_device parameter everywhere?

Its tempting, seems only af_packet uses it.  I'll see if there is
another (simpler) way of getting the orig ifindex into af_packet.