netdev - Re: [PATCH net-next] dsa: remove unused net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74dc3b77-67b9-286b-edbd-acec6cba3694@gmail.com>
Date:   Thu, 17 Aug 2017 11:53:56 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Florian Westphal <fw@...len.de>, Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, vivien.didelot@...oirfairelinux.com
Subject: Re: [PATCH net-next] dsa: remove unused net_device arg from handlers

On 08/17/2017 11:40 AM, Florian Westphal wrote:
> Andrew Lunn <andrew@...n.ch> wrote:
>> On Thu, Aug 17, 2017 at 04:47:00PM +0200, Florian Westphal wrote:
>>> compile tested only, but saw no warnings/errors with
>>> allmodconfig build.
>>>  
>>>  static int dsa_switch_rcv(struct sk_buff *skb, struct net_device *dev,
>>> -			  struct packet_type *pt, struct net_device *orig_dev)
>>> +			  struct packet_type *pt, struct net_device *unused)
>>
>> Hi Florian
>>
>> Looks O.K. to me. I can test it out later.
>>
>> Is there a bigger picture here? Do you plan to remove the second
>> net_device parameter everywhere?
> 
> Its tempting, seems only af_packet uses it.  I'll see if there is
> another (simpler) way of getting the orig ifindex into af_packet.
> 

FWIW, I still have some changes queued locally that make use of orig_dev
to support the switch tag HW insertion/extraction, but I think "dev"
here is equally suitable since it still points to the DSA master network
device.
-- 
Florian