netdev - Re: [PATCH 3/6] mpls: add VPLS entry points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201708200203.Lx6M5gpL%fengguang.wu@intel.com>
Date:   Sun, 20 Aug 2017 02:27:59 +0800
From:   kbuild test robot <lkp@...el.com>
To:     David Lamparter <equinox@...c24.net>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        amine.kherbouche@...nd.com, roopa@...ulusnetworks.com,
        David Lamparter <equinox@...c24.net>
Subject: Re: [PATCH 3/6] mpls: add VPLS entry points

Hi David,

[auto build test ERROR on net-next/master]
[also build test ERROR on next-20170817]
[cannot apply to v4.13-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/David-Lamparter/bridge-learn-dst-metadata-in-FDB/20170820-001849
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All error/warnings (new ones prefixed by >>):

   In file included from net/mpls/af_mpls.c:25:0:
>> net/mpls/internal.h:231:19: error: function declaration isn't a prototype [-Werror=strict-prototypes]
    static inline int vpls_rcv(skb, in_dev, pt, rt, hdr, orig_dev)
                      ^
   net/mpls/internal.h: In function 'vpls_rcv':
>> net/mpls/internal.h:233:2: warning: passing argument 1 of 'kfree_skb' makes pointer from integer without a cast
     kfree_skb(skb);
     ^
   In file included from net/mpls/af_mpls.c:2:0:
   include/linux/skbuff.h:956:6: note: expected 'struct sk_buff *' but argument is of type 'int'
    void kfree_skb(struct sk_buff *skb);
         ^
   net/mpls/af_mpls.c: In function 'mpls_rt_xmit':
   net/mpls/af_mpls.c:459:45: warning: 'out_dev' may be used uninitialized in this function [-Wmaybe-uninitialized]
     out_mdev = out_dev ? mpls_dev_get(out_dev) : NULL;
                                                ^
   cc1: some warnings being treated as errors
--
   In file included from net/mpls/mpls_iptunnel.c:28:0:
>> net/mpls/internal.h:231:19: error: function declaration isn't a prototype [-Werror=strict-prototypes]
    static inline int vpls_rcv(skb, in_dev, pt, rt, hdr, orig_dev)
                      ^
   net/mpls/internal.h: In function 'vpls_rcv':
>> net/mpls/internal.h:233:2: warning: passing argument 1 of 'kfree_skb' makes pointer from integer without a cast
     kfree_skb(skb);
     ^
   In file included from net/mpls/mpls_iptunnel.c:14:0:
   include/linux/skbuff.h:956:6: note: expected 'struct sk_buff *' but argument is of type 'int'
    void kfree_skb(struct sk_buff *skb);
         ^
   cc1: some warnings being treated as errors

vim +231 net/mpls/internal.h

   229	
   230	#else /* !CONFIG_MPLS_VPLS */
 > 231	static inline int vpls_rcv(skb, in_dev, pt, rt, hdr, orig_dev)
   232	{
 > 233		kfree_skb(skb);
   234		return NET_RX_DROP;
   235	}
   236	static inline int is_vpls_dev(struct net_device *dev)
   237	{
   238		return 0;
   239	}
   240	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (50949 bytes)