netdev - Re: [PATCH] net_sched: fix order of queue length updates in qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpX9C3r8OTeB3AjqwcDGbV=Yc_vid4YOzQML9cQ38UAhtw@mail.gmail.com>
Date:   Sat, 19 Aug 2017 10:58:37 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...nulli.us>, stable@...r.kernel.org
Subject: Re: [PATCH] net_sched: fix order of queue length updates in qdisc_replace()

On Sat, Aug 19, 2017 at 5:37 AM, Konstantin Khlebnikov
<khlebnikov@...dex-team.ru> wrote:
> This important to call qdisc_tree_reduce_backlog() after changing queue
> length. Parent qdisc should deactivate class in ->qlen_notify() called from
> qdisc_tree_reduce_backlog() but this happens only if qdisc->q.qlen in zero.

Good catch! I didn't realize qdisc_reset() actually resets all classes...

Acked-by: Cong Wang <xiyou.wangcong@...il.com>