netdev - Re: [PATCH] net_sched: fix order of queue length updates in qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170820.200155.1157969593060834432.davem@davemloft.net>
Date:   Sun, 20 Aug 2017 20:01:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     khlebnikov@...dex-team.ru
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH] net_sched: fix order of queue length updates in
 qdisc_replace()

From: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Date: Sat, 19 Aug 2017 15:37:07 +0300

> This important to call qdisc_tree_reduce_backlog() after changing queue
> length. Parent qdisc should deactivate class in ->qlen_notify() called from
> qdisc_tree_reduce_backlog() but this happens only if qdisc->q.qlen in zero.
> 
> Missed class deactivations leads to crashes/warnings at picking packets
> from empty qdisc and corrupting state at reactivating this class in future.
> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
> Fixes: 86a7996cc8a0 ("net_sched: introduce qdisc_replace() helper")

Applied and queued up for -stable, thanks.

Please do not add an explict "CC: stable" to networking patches, simply
ask me to queue it up as I handle all networking -stable submissions
myself by hand.

Thank you.