netdev - Re: [PATCH net-next 1/3 v6] net: ether: Add support for multiplexing and aggregation type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6dd2e0b7-51ec-18a3-07fb-3952a114b89a@mojatatu.com>
Date:   Sun, 20 Aug 2017 14:18:03 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>,
        netdev@...r.kernel.org, davem@...emloft.net,
        fengguang.wu@...el.com, dcbw@...hat.com, jiri@...nulli.us,
        stephen@...workplumber.org, David.Laight@...LAB.COM,
        marcel@...tmann.org
Subject: Re: [PATCH net-next 1/3 v6] net: ether: Add support for multiplexing
 and aggregation type

On 17-08-19 01:35 AM, Subash Abhinov Kasiviswanathan wrote:
> Define the multiplexing and aggregation (MAP) ether type 0xDA1A. This
> is needed for receiving data in the MAP protocol like RMNET. This is
> not an officially registered ID.
> 
> Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
> ---
>   include/uapi/linux/if_ether.h | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/if_ether.h b/include/uapi/linux/if_ether.h
> index 5bc9bfd..e80b03f 100644
> --- a/include/uapi/linux/if_ether.h
> +++ b/include/uapi/linux/if_ether.h
> @@ -104,7 +104,9 @@
>   #define ETH_P_QINQ3	0x9300		/* deprecated QinQ VLAN [ NOT AN OFFICIALLY REGISTERED ID ] */
>   #define ETH_P_EDSA	0xDADA		/* Ethertype DSA [ NOT AN OFFICIALLY REGISTERED ID ] */
>   #define ETH_P_AF_IUCV   0xFBFB		/* IBM af_iucv [ NOT AN OFFICIALLY REGISTERED ID ] */
> -
> +#define ETH_P_MAP       0xDA1A          /* Multiplexing and Aggregation Protocol
> +					 *  NOT AN OFFICIALLY REGISTERED ID ]

You cant just arbitrarly assign yourself an ethertype.
The IEEE may never issue you one - and if they do, it will likely not be
the one you want i.e above.

If there is a way for you to make this a config option that is not
hardcoded to some default value then that would be the best approach to
take.

cheers,
jamal