netdev - RE: [PATCH net-next 4/4] mlx4: sizeof style usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM2PR21MB0074E2B2C697B1300B77EFEACC860@DM2PR21MB0074.namprd21.prod.outlook.com>
Date:   Sun, 20 Aug 2017 18:00:27 +0000
From:   Stephen Hemminger <sthemmin@...rosoft.com>
To:     Tariq Toukan <tariqt@...lanox.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        "mlindner@...vell.com" <mlindner@...vell.com>,
        "mst@...hat.com" <mst@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>
Subject: RE: [PATCH net-next 4/4] mlx4: sizeof style usage

Yes, good catch.

-----Original Message-----
From: Tariq Toukan [mailto:tariqt@...lanox.com] 
Sent: Sunday, August 20, 2017 3:27 AM
To: Stephen Hemminger <stephen@...workplumber.org>; mlindner@...vell.com; mst@...hat.com; jasowang@...hat.com
Cc: netdev@...r.kernel.org; linux-rdma@...r.kernel.org; virtualization@...ts.linux-foundation.org; Stephen Hemminger <sthemmin@...rosoft.com>
Subject: Re: [PATCH net-next 4/4] mlx4: sizeof style usage

[You don't often get email from TARIQT@...LANOX.COM. Learn why this is important at http://aka.ms/LearnAboutSenderIdentification.]

Thanks Stephen.
Sorry for the late reply, I was on vacation.
I know this is already accepted, but still I have one comment.

On 15/08/2017 8:29 PM, Stephen Hemminger wrote:
> The kernel coding style is to treat sizeof as a function
> (ie. with parenthesis) not as an operator.
>
> Also use kcalloc and kmalloc_array
>
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> ---
> @@ -726,7 +726,7 @@ static int mlx4_eq_int(struct mlx4_dev *dev, struct mlx4_eq *eq)
>                       }
>                       memcpy(&priv->mfunc.master.comm_arm_bit_vector,
>                              eqe->event.comm_channel_arm.bit_vec,
> -                            sizeof eqe->event.comm_channel_arm.bit_vec);
> +                            sizeof(eqe)->event.comm_channel_arm.bit_vec);

I think the brackets here are misplaced.
Shouldn't they be as follows?

sizeof(eqe->event.comm_channel_arm.bit_vec));

>                       queue_work(priv->mfunc.master.comm_wq,
>                                  &priv->mfunc.master.comm_work);
>                       break;

Thanks,
Tariq