netdev - Re: [PATCH net-next 1/3 v6] net: ether: Add support for multiplexing and aggregation type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39c75b3d-2662-0a26-7752-fbcf9eea2781@mojatatu.com>
Date:   Mon, 21 Aug 2017 08:17:45 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     David Miller <davem@...emloft.net>
Cc:     subashab@...eaurora.org, netdev@...r.kernel.org,
        fengguang.wu@...el.com, dcbw@...hat.com, jiri@...nulli.us,
        stephen@...workplumber.org, David.Laight@...LAB.COM,
        marcel@...tmann.org
Subject: Re: [PATCH net-next 1/3 v6] net: ether: Add support for multiplexing
 and aggregation type

On 17-08-20 06:12 PM, David Miller wrote:

>>> +#define ETH_P_MAP 0xDA1A /* Multiplexing and Aggregation Protocol
>>> + * NOT AN OFFICIALLY REGISTERED ID ]
>>
>> You cant just arbitrarly assign yourself an ethertype.  The IEEE may
>> never issue you one - and if they do, it will likely not be the one
>> you want i.e above.
>>
>> If there is a way for you to make this a config option that is not
>> hardcoded to some default value then that would be the best approach
>> to take.
> 
> This may be a kind of a different situation, these ethertypes exist
> only internally in the kernel and never on the wire.
> 
> It's just controlling the demux on ethernet receive.
> 
> We have several IDs like this, and thus this addition is consistent
> with existing practice.

Ok, so if the IEEE issued this ID to someone there will be no conflict
then?
I checked - all the ether types listed in the header file as
"NOT AN OFFICIALLY REGISTERED ID" are not currently assigned by IEEE.

cheers,
jamal