netdev - RE: [PATCH net-next 1/3 v6] net: ether: Add support for multiplexing and aggregation type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6DD005CC8C@AcuExch.aculab.com>
Date:   Mon, 21 Aug 2017 15:00:14 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'David Miller' <davem@...emloft.net>,
        "jhs@...atatu.com" <jhs@...atatu.com>
CC:     "subashab@...eaurora.org" <subashab@...eaurora.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "fengguang.wu@...el.com" <fengguang.wu@...el.com>,
        "dcbw@...hat.com" <dcbw@...hat.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "stephen@...workplumber.org" <stephen@...workplumber.org>,
        "marcel@...tmann.org" <marcel@...tmann.org>
Subject: RE: [PATCH net-next 1/3 v6] net: ether: Add support for
 multiplexing and aggregation type

From: David Miller
> Sent: 20 August 2017 23:12
> From: Jamal Hadi Salim <jhs@...atatu.com>
> Date: Sun, 20 Aug 2017 14:18:03 -0400
> 
> > On 17-08-19 01:35 AM, Subash Abhinov Kasiviswanathan wrote:
> >> Define the multiplexing and aggregation (MAP) ether type 0xDA1A. This
> >> is needed for receiving data in the MAP protocol like RMNET. This is
> >> not an officially registered ID.
> >> Signed-off-by: Subash Abhinov Kasiviswanathan
> >> <subashab@...eaurora.org>
> >> ---
> >>   include/uapi/linux/if_ether.h | 4 +++-
> >>   1 file changed, 3 insertions(+), 1 deletion(-)
> >> diff --git a/include/uapi/linux/if_ether.h
> >> b/include/uapi/linux/if_ether.h
> >> index 5bc9bfd..e80b03f 100644
> >> --- a/include/uapi/linux/if_ether.h
> >> +++ b/include/uapi/linux/if_ether.h
> >> @@ -104,7 +104,9 @@
> >>   #define ETH_P_QINQ3 0x9300 /* deprecated QinQ VLAN [ NOT AN OFFICIALLY
> >>   #REGISTERED ID ] */
> >>   #define ETH_P_EDSA 0xDADA /* Ethertype DSA [ NOT AN OFFICIALLY
> >>   #REGISTERED ID ] */
> >>   #define ETH_P_AF_IUCV 0xFBFB /* IBM af_iucv [ NOT AN OFFICIALLY
> >>   #REGISTERED ID ] */
> >> -
> >> +#define ETH_P_MAP 0xDA1A /* Multiplexing and Aggregation Protocol
> >> + * NOT AN OFFICIALLY REGISTERED ID ]
> >
> > You cant just arbitrarly assign yourself an ethertype.  The IEEE may
> > never issue you one - and if they do, it will likely not be the one
> > you want i.e above.
> >
> > If there is a way for you to make this a config option that is not
> > hardcoded to some default value then that would be the best approach
> > to take.
> 
> This may be a kind of a different situation, these ethertypes exist
> only internally in the kernel and never on the wire.
> 
> It's just controlling the demux on ethernet receive.
> 
> We have several IDs like this, and thus this addition is consistent
> with existing practice.

Are they ever put into ethernet packets?
If not then use values below 1500.

	David