netdev - Re: [PATCH net-next v5] openvswitch: enable NSH support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201708230651.E6RQiLeI%fengguang.wu@intel.com>
Date:   Wed, 23 Aug 2017 06:26:25 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Yi Yang <yi.y.yang@...el.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, dev@...nvswitch.org,
        blp@....org, jbenc@...hat.com, e@...g.me,
        jan.scheurich@...csson.com, Yi Yang <yi.y.yang@...el.com>
Subject: Re: [PATCH net-next v5] openvswitch: enable NSH support

Hi Yi,

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Yi-Yang/openvswitch-enable-NSH-support/20170822-184251
config: x86_64-randconfig-a0-08230538 (attached as .config)
compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   net//openvswitch/flow.c: In function 'parse_nsh':
>> net//openvswitch/flow.c:498: warning: unused variable 'err'

vim +/err +498 net//openvswitch/flow.c

   493	
   494	static int parse_nsh(struct sk_buff *skb, struct sw_flow_key *key)
   495	{
   496		struct nsh_hdr *nsh = (struct nsh_hdr *)skb_network_header(skb);
   497		u8 version, length;
 > 498		int err;
   499	
   500		if (unlikely(skb->len < NSH_BASE_HDR_LEN))
   501			return -EINVAL;
   502	
   503		version = nsh_get_ver(nsh);
   504		length = nsh_hdr_len(nsh);
   505	
   506		if (version != 0)
   507			return -EINVAL;
   508	
   509		if (unlikely(skb->len < length))
   510			return -EINVAL;
   511	
   512		key->nsh.flags = nsh_get_flags(nsh);
   513		key->nsh.ttl = nsh_get_ttl(nsh);
   514		key->nsh.mdtype = nsh->md_type;
   515		key->nsh.np = nsh->next_proto;
   516		key->nsh.path_hdr = nsh->path_hdr;
   517		switch (key->nsh.mdtype) {
   518		case NSH_M_TYPE1:
   519			if (length != NSH_M_TYPE1_LEN)
   520				return -EINVAL;
   521			memcpy(key->nsh.context, nsh->md1.context,
   522			       sizeof(nsh->md1));
   523			break;
   524		case NSH_M_TYPE2:
   525			/* Don't support MD type 2 metedata parsing yet */
   526			if (length < NSH_BASE_HDR_LEN)
   527				return -EINVAL;
   528	
   529			memset(key->nsh.context, 0,
   530			       sizeof(nsh->md1));
   531			break;
   532		default:
   533			return -EINVAL;
   534		}
   535	
   536		return 0;
   537	}
   538	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (32416 bytes)