netdev - Re: [net-next 10/15] net/mlx5: Add a blank line after declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1503527941.27867.2.camel@perches.com>
Date:   Wed, 23 Aug 2017 15:39:01 -0700
From:   Joe Perches <joe@...ches.com>
To:     Saeed Mahameed <saeedm@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, Leon Romanovsky <leonro@...lanox.com>,
        Or Gerlitz <ogerlitz@...lanox.com>
Subject: Re: [net-next 10/15] net/mlx5: Add a blank line after declarations

On Thu, 2017-08-17 at 16:29 +0300, Saeed Mahameed wrote:
> From: Or Gerlitz <ogerlitz@...lanox.com>
[]
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eq.c b/drivers/net/ethernet/mellanox/mlx5/core/eq.c
[]
> @@ -188,6 +188,7 @@ static enum mlx5_dev_event port_subtype_event(u8 subtype)
>  static void eq_update_ci(struct mlx5_eq *eq, int arm)
>  {
>  	__be32 __iomem *addr = eq->doorbell + (arm ? 0 : 2);
> +
>  	u32 val = (eq->cons_index & 0xffffff) | (eq->eqn << 24);
>  	__raw_writel((__force u32)cpu_to_be32(val), addr);
>  	/* We still want ordering, just not swabbing, so add a barrier */

checkpatch is stupid.

The blank line should be after u32 val = ...
and not after __be32 __iomem *addr = ...