netdev - Re: [PATCH net-next] hinic: uninitialized variable in hinic_api_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63dafb26-dd90-bf64-bd41-48a844cdf924@huawei.com>
Date:   Thu, 24 Aug 2017 15:24:55 +0300
From:   Aviad Krawczyk <aviad.krawczyk@...wei.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     <netdev@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net-next] hinic: uninitialized variable in
 hinic_api_cmd_init()

On 8/24/2017 1:47 PM, Dan Carpenter wrote:
> We never set the error code in this function.
> 
> Fixes: eabf0fad81d5 ("net-next/hinic: Initialize api cmd resources")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c
> index 8901801fe426..c40603a183df 100644
> --- a/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c
> +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c
> @@ -941,6 +941,7 @@ int hinic_api_cmd_init(struct hinic_api_cmd_chain **chain,
>  		if (IS_ERR(chain[chain_type])) {
>  			dev_err(&pdev->dev, "Failed to create chain %d\n",
>  				chain_type);
> +			err = PTR_ERR(chain[chain_type]);
>  			goto err_create_chain;
>  		}
>  	}
> 
> 

Thanks a lot, Reviewed-by: Aviad Krawczyk <aviad.krawczyk@...wei.com>