netdev - Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings only on default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0UctVUqAU7XAoiDOm8dSB20dFT+75qDpn2u4kyJDZ-Usyw@mail.gmail.com>
Date:   Mon, 28 Aug 2017 09:25:46 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     "Neftin, Sasha" <sasha.neftin@...el.com>
Cc:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        <"jeffrey.t.kirsher@...el.com, alexander.h.duyck@...el.com, raanan.avargil@...el.com, dima.ruinskiy"@intel.com>,
        Netdev <netdev@...r.kernel.org>,
        Willem de Bruijn <willemb@...gle.com>,
        intel-wired-lan <intel-wired-lan@...ts.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH] e1000e: apply burst mode settings only
 on default

On Sun, Aug 27, 2017 at 1:30 AM, Neftin, Sasha <sasha.neftin@...el.com> wrote:
> On 8/25/2017 18:06, Willem de Bruijn wrote:
>>
>> From: Willem de Bruijn <willemb@...gle.com>
>>
>> Devices that support FLAG2_DMA_BURST have different default values
>> for RDTR and RADV. Apply burst mode default settings only when no
>> explicit value was passed at module load.
>>
>> The RDTR default is zero. If the module is loaded for low latency
>> operation with RxIntDelay=0, do not override this value with a burst
>> default of 32.
>>
>> Move the decision to apply burst values earlier, where explicitly
>> initialized module variables can be distinguished from defaults.
>>
>> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
>
> This patch looks good for me, but I would like hear second opinion.

This code is an improvement over what was already there. I am good with this.

Acked-by: Alexander Duyck <alexander.h.duyck@...el.com>