netdev - RE: [PATCH] e1000e: apply burst mode settings only on default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Sep 2017 23:48:29 +0000
From:   "Brown, Aaron F" <aaron.f.brown@...el.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:     "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: RE: [PATCH] e1000e: apply burst mode settings only on default

> From: netdev-owner@...r.kernel.org [mailto:netdev-
> owner@...r.kernel.org] On Behalf Of Willem de Bruijn
> Sent: Friday, August 25, 2017 8:06 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; Brandeburg,
> Jesse <jesse.brandeburg@...el.com>; Willem de Bruijn
> <willemb@...gle.com>
> Subject: [PATCH] e1000e: apply burst mode settings only on default
> 
> From: Willem de Bruijn <willemb@...gle.com>
> 
> Devices that support FLAG2_DMA_BURST have different default values
> for RDTR and RADV. Apply burst mode default settings only when no
> explicit value was passed at module load.
> 
> The RDTR default is zero. If the module is loaded for low latency
> operation with RxIntDelay=0, do not override this value with a burst
> default of 32.
> 
> Move the decision to apply burst values earlier, where explicitly
> initialized module variables can be distinguished from defaults.
> 
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
> ---
>  drivers/net/ethernet/intel/e1000e/e1000.h  |  4 ----
>  drivers/net/ethernet/intel/e1000e/netdev.c |  8 --------
>  drivers/net/ethernet/intel/e1000e/param.c  | 16 +++++++++++++++-
>  3 files changed, 15 insertions(+), 13 deletions(-)

Tested-by: Aaron Brown <aaron.f.brown@...el.com>