netdev - Re: [PATCH net-next] dp83640: don't hold spinlock while calling netif_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170830.145031.1158341283102125578.davem@davemloft.net>
Date:   Wed, 30 Aug 2017 14:50:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     stefan.sorensen@...ctralink.com
Cc:     richardcochran@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] dp83640: don't hold spinlock while calling
 netif_rx_ni

From: Stefan Sørensen <stefan.sorensen@...ctralink.com>
Date: Wed, 30 Aug 2017 08:58:47 +0200

> We should not hold a spinlock while pushing the skb into the networking
> stack, so move the call to netif_rx_ni out of the critical region to where
> we have dropped the spinlock.
> 
> Signed-off-by: Stefan Sørensen <stefan.sorensen@...ctralink.com>

Looks good, applied, thanks.