netdev - Re: [PATCH net-next] dp83640: don't hold spinlock while calling netif_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170831072557.i5tnrb64fohlj56p@localhost>
Date:   Thu, 31 Aug 2017 09:25:57 +0200
From:   Richard Cochran <richardcochran@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     stefan.sorensen@...ctralink.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] dp83640: don't hold spinlock while calling
 netif_rx_ni

On Wed, Aug 30, 2017 at 02:50:31PM -0700, David Miller wrote:
> From: Stefan Sørensen <stefan.sorensen@...ctralink.com>
> Date: Wed, 30 Aug 2017 08:58:47 +0200
> 
> > We should not hold a spinlock while pushing the skb into the networking
> > stack, so move the call to netif_rx_ni out of the critical region to where
> > we have dropped the spinlock.
> > 
> > Signed-off-by: Stefan Sørensen <stefan.sorensen@...ctralink.com>
> 
> Looks good, applied, thanks.

And thanks, Stefan, for following up on this.  For the record, we
discussed this fix back in April.

    https://patchwork.ozlabs.org/patch/752201/

Cheers,
Richard