netdev - RE: [patch net-next v2 3/3] net/sched: Change act_api and act

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0501MB214338E35631CF03BAA74CD7AB9D0@VI1PR0501MB2143.eurprd05.prod.outlook.com>
Date:   Thu, 31 Aug 2017 01:05:04 +0000
From:   Chris Mi <chrism@...lanox.com>
To:     Jamal Hadi Salim <jhs@...atatu.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "mawilcox@...rosoft.com" <mawilcox@...rosoft.com>
Subject: RE: [patch net-next v2 3/3] net/sched: Change act_api and act_xxx
 modules to use IDR



> -----Original Message-----
> From: Jamal Hadi Salim [mailto:jhs@...atatu.com]
> Sent: Wednesday, August 30, 2017 8:11 PM
> To: Chris Mi <chrism@...lanox.com>; netdev@...r.kernel.org
> Cc: xiyou.wangcong@...il.com; jiri@...nulli.us; davem@...emloft.net;
> mawilcox@...rosoft.com
> Subject: Re: [patch net-next v2 3/3] net/sched: Change act_api and act_xxx
> modules to use IDR
> 
> On 17-08-30 02:31 AM, Chris Mi wrote:
> > Typically, each TC filter has its own action. All the actions of the
> > same type are saved in its hash table. But the hash buckets are too
> > small that it degrades to a list. And the performance is greatly
> > affected. For example, it takes about 0m11.914s to insert 64K rules.
> > If we convert the hash table to IDR, it only takes about 0m1.500s.
> > The improvement is huge.
> >
> > But please note that the test result is based on previous patch that
> > cls_flower uses IDR.
> >
> > Signed-off-by: Chris Mi <chrism@...lanox.com>
> > Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> 
> Acked-by: Jamal Hadi Salim <jhs@...atatu.com>
> 
> Also already acked this before but you left it out in this version. If you make
> changes to the patch then you will need a new ACK.
Sorry about that, Jamal. I think I need to make a note of the review comment
In case I forget it.
> 
> Dont forget to update selftests please.
Sure, we will work on that.

Thanks,
Chris
> 
> cheers,
> jamal