netdev - RE: [patch net-next v2 0/3] net/sched: Improve getting objects by indexes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0501MB21431977FD1FCECC1D3AC1FCAB9D0@VI1PR0501MB2143.eurprd05.prod.outlook.com>
Date:   Thu, 31 Aug 2017 01:05:40 +0000
From:   Chris Mi <chrism@...lanox.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "mawilcox@...rosoft.com" <mawilcox@...rosoft.com>
Subject: RE: [patch net-next v2 0/3] net/sched: Improve getting objects by
 indexes



> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Thursday, August 31, 2017 5:39 AM
> To: Chris Mi <chrism@...lanox.com>
> Cc: netdev@...r.kernel.org; jhs@...atatu.com;
> xiyou.wangcong@...il.com; jiri@...nulli.us; mawilcox@...rosoft.com
> Subject: Re: [patch net-next v2 0/3] net/sched: Improve getting objects by
> indexes
> 
> From: Chris Mi <chrism@...lanox.com>
> Date: Wed, 30 Aug 2017 02:31:56 -0400
> 
> > Using current TC code, it is very slow to insert a lot of rules.
> >
> > In order to improve the rules update rate in TC, we introduced the
> > following two changes:
> >         1) changed cls_flower to use IDR to manage the filters.
> >         2) changed all act_xxx modules to use IDR instead of
> >            a small hash table
> >
> > But IDR has a limitation that it uses int. TC handle uses u32.
> > To make sure there is no regression, we add several new IDR APIs to
> > support unsigned long.
> >
> > v2
> > ==
> >
> > Addressed Hannes's comment:
> > express idr_alloc in terms of idr_alloc_ext and most of the other
> > functions
> 
> Series applied, thanks.

Thank you, David,

-Chris