netdev - Re: [PATCH net-next 09/12] net: dsa: b53: Wire-up EEE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mv5r1vzx.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
Date:   Mon, 18 Sep 2017 18:29:22 -0400
From:   Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, andrew@...n.ch,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next 09/12] net: dsa: b53: Wire-up EEE

Hi Florian,

Florian Fainelli <f.fainelli@...il.com> writes:

> @@ -1000,6 +1005,9 @@ static void b53_adjust_link(struct dsa_switch *ds, int port,
>  			b53_write8(dev, B53_CTRL_PAGE, po_reg, gmii_po);
>  		}
>  	}
> +
> +	/* Re-negotiate EEE if it was enabled already */
> +	p->eee_enabled = b53_eee_init(ds, port, phydev);
>  }

Same here, I think we can move this up to DSA core, maybe with a
eee_enabled mask in dsa_switch or a bool in dsa_port.