netdev - Re: [PATCH net-next 08/12] net: dsa: b53: Move EEE functions to b53

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f76ae4bb-b2d4-7b2f-d465-527967f9f5e5@gmail.com>
Date:   Mon, 18 Sep 2017 15:33:52 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        netdev@...r.kernel.org
Cc:     davem@...emloft.net, andrew@...n.ch
Subject: Re: [PATCH net-next 08/12] net: dsa: b53: Move EEE functions to b53

On 09/18/2017 03:27 PM, Vivien Didelot wrote:
> Hi Florian,
> 
> Florian Fainelli <f.fainelli@...il.com> writes:
> 
>> @@ -649,7 +595,7 @@ static void bcm_sf2_sw_adjust_link(struct dsa_switch *ds, int port,
>>  	core_writel(priv, reg, offset);
>>  
>>  	if (!phydev->is_pseudo_fixed_link)
>> -		p->eee_enabled = bcm_sf2_eee_init(ds, port, phydev);
>> +		p->eee_enabled = b53_eee_init(ds, port, phydev);
>>  }
> 
> I know this is a bit out-of-scope of this patch, but I have to say I am
> not confortable with having still phy device stuffs in switch drivers...

Yes, this is out of scope :)

> 
> Can this is_pseudo_fixed_link check + phy_eee_init + eee_enable be moved
> up to dsa_slave_adjust_link in a future patch maybe?

Not 100% positive this applies to all switches, which is why this is
still largely a switch driver decision.
-- 
Florian