netdev - Re: [PATCH] bpf: devmap: pass on return value of bpf_map_precharge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170918.165357.480851390980422798.davem@davemloft.net>
Date:   Mon, 18 Sep 2017 16:53:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tklauser@...tanz.ch
Cc:     ast@...nel.org, daniel@...earbox.net, john.fastabend@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] bpf: devmap: pass on return value of
 bpf_map_precharge_memlock

From: Tobias Klauser <tklauser@...tanz.ch>
Date: Mon, 18 Sep 2017 15:03:46 +0200

> If bpf_map_precharge_memlock in dev_map_alloc, -ENOMEM is returned
> regardless of the actual error produced by bpf_map_precharge_memlock.
> Fix it by passing on the error returned by bpf_map_precharge_memlock.
> 
> Also return -EINVAL instead of -ENOMEM if the page count overflow check
> fails.
> 
> This makes dev_map_alloc match the behavior of other bpf maps' alloc
> functions wrt. return values.
> 
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

Applied, thank you.