netdev - Re: [PATCH net-next ] net: Remove useless function skb_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1505969350.12311.20.camel@perches.com>
Date:   Wed, 20 Sep 2017 21:49:10 -0700
From:   Joe Perches <joe@...ches.com>
To:     gfree.wind@....163.com, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next ] net: Remove useless function
 skb_header_release

On Thu, 2017-09-21 at 12:39 +0800, gfree.wind@....163.com wrote:
> From: Gao Feng <gfree.wind@....163.com>
> 
> There is no one which would invokes the function skb_header_release.
> So just remove it now.

This in incomplete.
There are other references to this function.

$ git grep -w skb_header_release
drivers/net/usb/asix_common.c:	 * TCP packets for example are cloned, but skb_header_release()
include/linux/skbuff.h: *	skb_header_release - release reference to header
include/linux/skbuff.h:static inline void skb_header_release(struct sk_buff *skb)
include/linux/skbuff.h: *	Variant of skb_header_release() assuming skb is private to caller.
net/batman-adv/soft-interface.c:	 * data using skb_header_release in our skbs to allow skb_cow_header to