netdev - Re:Re: [PATCH net-next ] net: Remove useless function skb_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <759c980e.47d8.15ea2d5de95.Coremail.gfree.wind@vip.163.com>
Date:   Thu, 21 Sep 2017 13:07:58 +0800 (CST)
From:   "Gao Feng" <gfree.wind@....163.com>
To:     "Joe Perches" <joe@...ches.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re:Re: [PATCH net-next ] net: Remove useless function
 skb_header_release

>On Thu, 2017-09-21 at 12:39 +0800, gfree.wind@....163.com wrote:
>> From: Gao Feng <gfree.wind@....163.com>
>> 
>> There is no one which would invokes the function skb_header_release.
>> So just remove it now.
>
>This in incomplete.
>There are other references to this function.
>
>$ git grep -w skb_header_release
>drivers/net/usb/asix_common.c:	 * TCP packets for example are cloned, but skb_header_release()
>include/linux/skbuff.h: *	skb_header_release - release reference to header
>include/linux/skbuff.h:static inline void skb_header_release(struct sk_buff *skb)
>include/linux/skbuff.h: *	Variant of skb_header_release() assuming skb is private to caller.
>net/batman-adv/soft-interface.c:	 * data using skb_header_release in our skbs to allow skb_cow_header to

But there are comments, not real codes.

Unless the skb_header_release may be used in the external modules

Best Regards
Feng