netdev - Re: [PATCH 2/6] ath9k: add a quirk to set use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878th14kde.fsf@kamboji.qca.qualcomm.com>
Date:   Tue, 26 Sep 2017 17:14:53 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     AceLan Kao <acelan.kao@...onical.com>,
        QCA ath9k Development <ath9k-devel@....qualcomm.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        "Linux-Kernel\@Vger. Kernel. Org" <linux-kernel@...r.kernel.org>,
        Daniel Drake <drake@...lessm.com>
Subject: Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

Christoph Hellwig <hch@...radead.org> writes:

> On Tue, Sep 26, 2017 at 03:26:51PM +0800, AceLan Kao wrote:
>> Ath9k is an old driver for old chips, and they work fine with legacy INTx.
>> But some new platforms are using it, so I think we should list those
>> new platforms which blocks INTx in the driver.
>
> And unless they are broken and need a quirk they should work even better
> with MSI if the device advertises MSI support in the PCI capabilities.

Daniel Drake (CCed) already found problems with the MSI implementation:

https://lkml.kernel.org/r/20170925041153.26574-1-drake@endlessm.com

-- 
Kalle Valo