netdev - Re: [PATCH net-next 3/6] bpf: update bpf.h uapi header for tools

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170927091050.469a3e08@redhat.com>
Date:   Wed, 27 Sep 2017 09:10:50 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     davem@...emloft.net, alexei.starovoitov@...il.com,
        john.fastabend@...il.com, peter.waskiewicz.jr@...el.com,
        jakub.kicinski@...ronome.com, netdev@...r.kernel.org,
        brouer@...hat.com
Subject: Re: [PATCH net-next 3/6] bpf: update bpf.h uapi header for tools

On Wed, 27 Sep 2017 09:03:34 +0200
Jesper Dangaard Brouer <brouer@...hat.com> wrote:

> On Mon, 25 Sep 2017 02:25:52 +0200
> Daniel Borkmann <daniel@...earbox.net> wrote:
> 
> > Looks like a couple of updates missed to get carried into tools/include/uapi/,
> > so copy the bpf.h header as usual to pull in latest updates.
> > 
> > Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> > Acked-by: Alexei Starovoitov <ast@...nel.org>
> > Acked-by: John Fastabend <john.fastabend@...il.com>
> > ---
> >  tools/include/uapi/linux/bpf.h | 45 ++++++++++++++++++++++++++++++------------
> >  1 file changed, 32 insertions(+), 13 deletions(-)
> > 
> > diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
> > index 461811e..e43491a 100644
> > --- a/tools/include/uapi/linux/bpf.h
> > +++ b/tools/include/uapi/linux/bpf.h
> > @@ -143,12 +143,6 @@ enum bpf_attach_type {
> >  
> >  #define MAX_BPF_ATTACH_TYPE __MAX_BPF_ATTACH_TYPE
> >  
> > -enum bpf_sockmap_flags {
> > -	BPF_SOCKMAP_UNSPEC,
> > -	BPF_SOCKMAP_STRPARSER,
> > -	__MAX_BPF_SOCKMAP_FLAG
> > -};
> > -  
> 
> Why does "bpf_sockmap_flags" gets removed?
> 
> It got added in: commit 69e8cc134bcb ("bpf: sockmap sample program").
> But I cannot find any users of these flags, so I guess it is okay.

Found the explanation in commit 2f857d04601 ("bpf: sockmap, remove
STRPARSER map_flags and add multi-map support").
 https://git.kernel.org/torvalds/c/2f857d04601

Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer