netdev - Re: [iproute PATCH] ip-route: Fix for listing routes with RTAX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170929120256.79894617@xeon-e3>
Date:   Fri, 29 Sep 2017 12:02:56 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Phil Sutter <phil@....cc>
Cc:     netdev@...r.kernel.org, Thomas Haller <thaller@...hat.com>,
        Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [iproute PATCH] ip-route: Fix for listing routes with RTAX_LOCK
 attribute

On Thu, 28 Sep 2017 19:33:56 +0200
Phil Sutter <phil@....cc> wrote:

> This fixes a corner-case for routes with a certain metric locked to
> zero:
> 
> | ip route add 192.168.7.0/24 dev eth0 window 0
> | ip route add 192.168.7.0/24 dev eth0 window lock 0
> 
> Since the kernel doesn't dump the attribute if it is zero, both routes
> added above would appear as if they were equal although they are not.
> 
> Fix this by taking mxlock value for the given metric into account before
> skipping it if it is not present.
> 
> Reported-by: Thomas Haller <thaller@...hat.com>
> Signed-off-by: Phil Sutter <phil@....cc>

Looks good, Applied. Thanks Phil