[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAGnkfhx0v8XULWBQ2eWOPf_=wsVTmiABJ8O_FBrf7ckzP+HRZQ@mail.gmail.com>
Date: Fri, 29 Sep 2017 12:47:09 +0200
From: Matteo Croce <mcroce@...hat.com>
To: Erik Kline <ek@...gle.com>
Cc: David Miller <davem@...emloft.net>,
netdev <netdev@...r.kernel.org>, linux-doc@...r.kernel.org
Subject: Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers
On Thu, Sep 28, 2017 at 1:22 PM, Erik Kline <ek@...gle.com> wrote:
> Upon further reflection, doesn't the whole premise of this change
> means that it's no longer possible to selectively disable these
> features if they are set on "all"? Or are we saying that this mode is
> only support with "default" enable + "ifname" disable?
Hi Erik, thanks for the review.
Yes the behaviour seems wrong when writing all.accept_dad respect what
the documentation says.
BTW the previous behaviour was not defined, I put them in OR because
that's what other handlers do, eg. send_redirects.
If you think that it's better to put them in AND we can change the
documentation accordingly.
What do you think?
--
Matteo Croce
per aspera ad upstream
Powered by blists - more mailing lists