netdev - Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAedzxrLurc=oGy64ePO30j3QQ_sL5kJCEz+RnTk3LMSn_yvyQ@mail.gmail.com>
Date:   Thu, 28 Sep 2017 20:22:26 +0900
From:   Erik Kline <ek@...gle.com>
To:     David Miller <davem@...emloft.net>
Cc:     mcroce@...hat.com, netdev <netdev@...r.kernel.org>,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH net] ipv6: fix net.ipv6.conf.all interface DAD handlers

On 28 September 2017 at 13:47, Erik Kline <ek@...gle.com> wrote:
>> Erik, please review.
>
> I apologize for the delay. I see that you've already applied this, and
> it's mostly LGTM except I have one thing I'm not seeing clearly.
>
> The documentation accept_dad  now claims:
>
>     DAD operation and mode on a given interface will be selected according
>     to the maximum value of conf/{all,interface}/accept_dad.
>
> but I'm try to square this with my reading of the changes to
> addrconf_dad_begin().  I think setting all.accept_dad to 0 but
> ifname.accept_dad to non-0 still results in the short-circuit call to
> addrconf_dad_completed().
>
> Am I just not seeing (thinking) straight?

Upon further reflection, doesn't the whole premise of this change
means that it's no longer possible to selectively disable these
features if they are set on "all"?  Or are we saying that this mode is
only support with "default" enable + "ifname" disable?

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4835 bytes)