netdev - Re: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171002153718.GJ17713@lunn.ch>
Date:   Mon, 2 Oct 2017 17:37:18 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Razvan Stefanescu <razvan.stefanescu@....com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        agraf@...e.de, arnd@...db.de, alexandru.marginean@....com,
        bogdan.purcareata@....com, ruxandra.radulescu@....com,
        laurentiu.tudor@....com, stuyoder@...il.com
Subject: Re: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

Hi Razvan

> +static void ethsw_get_drvinfo(struct net_device *netdev,
> +			      struct ethtool_drvinfo *drvinfo)
> +{
> +	struct ethsw_port_priv *port_priv = netdev_priv(netdev);
> +	u16 version_major, version_minor;
> +	int err;
> +
> +	strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver));
> +	strlcpy(drvinfo->version, ethsw_drv_version, sizeof(drvinfo->version));

Software driver versions are mostly useless. I would suggest you
remove this.

       Andrew