netdev - RE: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM3PR04MB074387851364E6F24ECF4502E6720@AM3PR04MB0743.eurprd04.prod.outlook.com>
Date:   Tue, 3 Oct 2017 05:22:06 +0000
From:   Razvan Stefanescu <razvan.stefanescu@....com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "agraf@...e.de" <agraf@...e.de>, "arnd@...db.de" <arnd@...db.de>,
        Alexandru Marginean <alexandru.marginean@....com>,
        Bogdan Purcareata <bogdan.purcareata@....com>,
        Ruxandra Ioana Radulescu <ruxandra.radulescu@....com>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        "stuyoder@...il.com" <stuyoder@...il.com>
Subject: RE: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support



> -----Original Message-----
> From: Andrew Lunn [mailto:andrew@...n.ch]
> Sent: Monday, October 02, 2017 18:37
> To: Razvan Stefanescu <razvan.stefanescu@....com>
> Cc: gregkh@...uxfoundation.org; devel@...verdev.osuosl.org; linux-
> kernel@...r.kernel.org; netdev@...r.kernel.org; agraf@...e.de;
> arnd@...db.de; Alexandru Marginean <alexandru.marginean@....com>;
> Bogdan Purcareata <bogdan.purcareata@....com>; Ruxandra Ioana Radulescu
> <ruxandra.radulescu@....com>; Laurentiu Tudor <laurentiu.tudor@....com>;
> stuyoder@...il.com
> Subject: Re: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support
> 
> Hi Razvan
> 
> > +static void ethsw_get_drvinfo(struct net_device *netdev,
> > +			      struct ethtool_drvinfo *drvinfo)
> > +{
> > +	struct ethsw_port_priv *port_priv = netdev_priv(netdev);
> > +	u16 version_major, version_minor;
> > +	int err;
> > +
> > +	strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver));
> > +	strlcpy(drvinfo->version, ethsw_drv_version, sizeof(drvinfo->version));
> 
> Software driver versions are mostly useless. I would suggest you
> remove this.
> 
>        Andrew
Thank you. I'll remove it in v3.

Best regards,
Razvan S.